third_party/WebKit/Source/platform/network/HeaderFieldTokenizer.cpp - Issue 2889033002: Better header value parsing for Server-Timing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/network/HeaderFieldTokenizer.cpp

Issue 2889033002: Better header value parsing for Server-Timing. (Closed)

Patch Set: init description as empty string for readability Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "platform/network/HeaderFieldTokenizer.h"	5 #include "platform/network/HeaderFieldTokenizer.h"

6	6

7 #include "platform/wtf/text/StringBuilder.h"	7 #include "platform/wtf/text/StringBuilder.h"

8 #include "platform/wtf/text/StringView.h"	8 #include "platform/wtf/text/StringView.h"

9	9

10 namespace blink {	10 namespace blink {

(...skipping 100 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
111 return ConsumeQuotedString(output);	111 return ConsumeQuotedString(output);

112	112

113 StringView view;	113 StringView view;

114 if (!ConsumeToken(mode, view))	114 if (!ConsumeToken(mode, view))

115 return false;	115 return false;

116 output = view.ToString();	116 output = view.ToString();

117 return true;	117 return true;

118 }	118 }

119	119

120 void HeaderFieldTokenizer::SkipSpaces() {	120 void HeaderFieldTokenizer::SkipSpaces() {

121 while (!IsConsumed() && input_[index_] == ' ')	121 while (!IsConsumed() && (input_[index_] == ' ' \|\| input_[index_] == '\t'))
	Mike West 2017/06/09 08:13:44 Hrm. On the one hand, sure, let's skip tabs. On th Hrm. On the one hand, sure, let's skip tabs. On the other, why aren't we skipping other control characters? https://infra.spec.whatwg.org/#ascii-whitespace defines ASCII whitespace to include some other characters. Can you point to docs that describe the rule this is implementing, and perhaps add a comment to that effect? Is this what's defined in https://tools.ietf.org/html/rfc7230#section-3.2.6 (because that section seems to have more limitations on the character set than we have here.
122 ++index_;	122 ++index_;

123 }	123 }

124	124

125 } // namespace blink	125 } // namespace blink

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/platform/network/HTTPParsersTest.cpp ('k') | no next file » | no next file with comments »