[Bluetooth] Standardize Bluetooth device address format to XX:XX:XX:XX:XX:XX.

[Bluetooth] Standardize Bluetooth device address format to XX:XX:XX:XX:XX:XX.

BUG=371014
TEST=device_unittests
R=keybuk@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271179

[Ilya Sherman, 2014-05-15 03:35:24]

/cc xiyuan and rpaquay as FYI.

I've tested this on Mac, but not on Windows or ChromeOS.  The changes are simple
enough to where they're probably right on all platforms, but it can't hurt to
double-check.  (I would check, but I don't have build environments set up for
either platform.)

[keybuk, 2014-05-15 03:48:13]

https://codereview.chromium.org/288903003/diff/30001/device/device_tests.gyp
File device/device_tests.gyp (right):

https://codereview.chromium.org/288903003/diff/30001/device/device_tests.gyp#...
device/device_tests.gyp:28: 'bluetooth/bluetooth_device_unittest.cc',
git add? ;-)

[Ilya Sherman, 2014-05-15 04:18:44]

https://codereview.chromium.org/288903003/diff/30001/device/device_tests.gyp
File device/device_tests.gyp (right):

https://codereview.chromium.org/288903003/diff/30001/device/device_tests.gyp#...
device/device_tests.gyp:28: 'bluetooth/bluetooth_device_unittest.cc',
On 2014/05/15 03:48:13, keybuk wrote:
> git add? ;-)

Uh, good call :P  Done.

[keybuk, 2014-05-15 21:33:05]

lgtm

https://codereview.chromium.org/288903003/diff/50001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter.cc (right):

https://codereview.chromium.org/288903003/diff/50001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter.cc:76: std::string normalized_address =
nit: canonicalized ;-)

[Ilya Sherman, 2014-05-15 21:42:28]

https://codereview.chromium.org/288903003/diff/50001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter.cc (right):

https://codereview.chromium.org/288903003/diff/50001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter.cc:76: std::string normalized_address =
On 2014/05/15 21:33:05, keybuk wrote:
> nit: canonicalized ;-)

Done.

[Ilya Sherman, 2014-05-15 21:43:58]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-05-15 21:44:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/288903003/70001

[commit-bot: I haz the power, 2014-05-15 23:46:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[Ilya Sherman, 2014-05-16 00:00:53]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-05-16 00:01:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/288903003/90001

[commit-bot: I haz the power, 2014-05-16 03:25:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Ilya Sherman, 2014-05-16 03:32:32]

keybuk@, I found myself needing to update
chromeos/dbus/fake_bluetooth_adapter_client.cc to use uppercase as well.  I'm a
little worried that the case difference might break other ChromeOS Bluetooth
code that expects lowercase casing.  Do you know whether there's any ChromeOS
that might have such a dependency?

[Ilya Sherman, 2014-05-16 22:59:29]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:32:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/288903003/110001

[commit-bot: I haz the power, 2014-05-17 05:49:50]

Change committed as 271179

[keybuk, 2014-05-19 19:53:26]

On 2014/05/16 03:32:32, Ilya Sherman wrote:
> keybuk@, I found myself needing to update
> chromeos/dbus/fake_bluetooth_adapter_client.cc to use uppercase as well.  I'm
a
> little worried that the case difference might break other ChromeOS Bluetooth
> code that expects lowercase casing.  Do you know whether there's any ChromeOS
> that might have such a dependency?

This is just hand-typed stuff to fake devices

If it breaks, the tests should pick it up ;-)
In fact, you've probably just inadvertently tested that your changes work on
CrOS because I bet the runtest.js is using lower-case too
If they don't, we'll write new tests