content/common/gpu/media/v4l2_image_processor.cc - Issue 288903002: fix sign-compare warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_image_processor.cc

Issue 288903002: fix sign-compare warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix sign-compare warning. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/v4l2_image_processor.cc

diff --git a/content/common/gpu/media/v4l2_image_processor.cc b/content/common/gpu/media/v4l2_image_processor.cc

index 67303daabc57f29a1ff10e504f706f677f022b1e..80650d817fba75a8323a9bd8aabc73d342c8929e 100644

--- a/content/common/gpu/media/v4l2_image_processor.cc

+++ b/content/common/gpu/media/v4l2_image_processor.cc

@@ -119,9 +119,9 @@ bool V4L2ImageProcessor::Initialize(media::VideoFrame::Format input_format,

output_allocated_size_ = output_allocated_size;

input_planes_count_ = media::VideoFrame::NumPlanes(input_format);

- DCHECK_LE(input_planes_count_, VIDEO_MAX_PLANES);

+ DCHECK_LE(input_planes_count_, static_cast<unsigned int>(VIDEO_MAX_PLANES));

output_planes_count_ = media::VideoFrame::NumPlanes(output_format);

- DCHECK_LE(output_planes_count_, VIDEO_MAX_PLANES);

+ DCHECK_LE(output_planes_count_, static_cast<unsigned int>(VIDEO_MAX_PLANES));

xhwang 2014/05/15 17:42:24 You should cast this to size_t.

yunlian 2014/05/15 17:47:53 Done.

// Capabilities check.

struct v4l2_capability caps;