content/common/gpu/media/v4l2_video_encode_accelerator.cc - Issue 288903002: fix sign-compare warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_encode_accelerator.cc

Issue 288903002: fix sign-compare warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/v4l2_video_encode_accelerator.cc

diff --git a/content/common/gpu/media/v4l2_video_encode_accelerator.cc b/content/common/gpu/media/v4l2_video_encode_accelerator.cc

index 0dd33a06ad33cbdf260c53055a585e247d416576..06ba07219cb58022d15b865cf76bd1cf61067b81 100644

--- a/content/common/gpu/media/v4l2_video_encode_accelerator.cc

+++ b/content/common/gpu/media/v4l2_video_encode_accelerator.cc

@@ -872,7 +872,7 @@ bool V4L2VideoEncodeAccelerator::NegotiateInputFormat(

return false;

}

- size_t input_planes_count = media::VideoFrame::NumPlanes(input_format);

+ int input_planes_count = media::VideoFrame::NumPlanes(input_format);

xhwang 2014/05/15 00:51:45 What problem is this causing? converting from int

yunlian 2014/05/15 16:34:13 The problem is in the DCHECK_LE in the following l

DCHECK_LE(input_planes_count, VIDEO_MAX_PLANES);

// First see if we the device can use the provided input_format directly.