Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288903002: fix sign-compare warning. (Closed)

Created:
6 years, 7 months ago by yunlian
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

fix sign-compare warning. BUG=chromium:373548 TEST=the warnings are gone. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271041

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix sign-compare warning. #

Total comments: 4

Patch Set 3 : fix sign-compare warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/common/gpu/media/exynos_v4l2_video_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_image_processor.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
yunlian
6 years, 7 months ago (2014-05-15 00:40:17 UTC) #1
xhwang
https://codereview.chromium.org/288903002/diff/1/content/common/gpu/media/v4l2_image_processor.cc File content/common/gpu/media/v4l2_image_processor.cc (right): https://codereview.chromium.org/288903002/diff/1/content/common/gpu/media/v4l2_image_processor.cc#newcode122 content/common/gpu/media/v4l2_image_processor.cc:122: DCHECK_LE(static_cast<int>(input_planes_count_), VIDEO_MAX_PLANES); Can you do it the other way ...
6 years, 7 months ago (2014-05-15 00:51:44 UTC) #2
xhwang
BTW, please fix the typo "sing" in the CL title.
6 years, 7 months ago (2014-05-15 00:52:35 UTC) #3
yunlian
https://codereview.chromium.org/288903002/diff/1/content/common/gpu/media/v4l2_image_processor.cc File content/common/gpu/media/v4l2_image_processor.cc (right): https://codereview.chromium.org/288903002/diff/1/content/common/gpu/media/v4l2_image_processor.cc#newcode122 content/common/gpu/media/v4l2_image_processor.cc:122: DCHECK_LE(static_cast<int>(input_planes_count_), VIDEO_MAX_PLANES); On 2014/05/15 00:51:45, xhwang wrote: > Can ...
6 years, 7 months ago (2014-05-15 16:34:12 UTC) #4
xhwang
https://codereview.chromium.org/288903002/diff/20001/content/common/gpu/media/v4l2_image_processor.cc File content/common/gpu/media/v4l2_image_processor.cc (right): https://codereview.chromium.org/288903002/diff/20001/content/common/gpu/media/v4l2_image_processor.cc#newcode124 content/common/gpu/media/v4l2_image_processor.cc:124: DCHECK_LE(output_planes_count_, static_cast<unsigned int>(VIDEO_MAX_PLANES)); You should cast this to size_t. ...
6 years, 7 months ago (2014-05-15 17:42:24 UTC) #5
yunlian
https://codereview.chromium.org/288903002/diff/20001/content/common/gpu/media/v4l2_image_processor.cc File content/common/gpu/media/v4l2_image_processor.cc (right): https://codereview.chromium.org/288903002/diff/20001/content/common/gpu/media/v4l2_image_processor.cc#newcode124 content/common/gpu/media/v4l2_image_processor.cc:124: DCHECK_LE(output_planes_count_, static_cast<unsigned int>(VIDEO_MAX_PLANES)); On 2014/05/15 17:42:24, xhwang wrote: > ...
6 years, 7 months ago (2014-05-15 17:47:53 UTC) #6
xhwang
lgtm, thanks!
6 years, 7 months ago (2014-05-15 20:01:43 UTC) #7
yunlian
The CQ bit was checked by yunlian@chromium.org
6 years, 7 months ago (2014-05-15 20:35:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/288903002/40001
6 years, 7 months ago (2014-05-15 20:36:43 UTC) #9
yunlian
The CQ bit was unchecked by yunlian@chromium.org
6 years, 7 months ago (2014-05-15 22:13:34 UTC) #10
yunlian
The CQ bit was checked by yunlian@chromium.org
6 years, 7 months ago (2014-05-15 22:13:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/288903002/40001
6 years, 7 months ago (2014-05-15 22:14:04 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 23:20:00 UTC) #13
commit-bot: I haz the power
Failed to apply patch for @master/content/common/gpu/media/exynos_v4l2_video_device.cc: While running svn add @master --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 7 months ago (2014-05-15 23:20:01 UTC) #14
yunlian
The CQ bit was checked by yunlian@chromium.org
6 years, 7 months ago (2014-05-16 17:05:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/288903002/40001
6 years, 7 months ago (2014-05-16 17:06:21 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 17:07:33 UTC) #17
Message was sent while issue was closed. 
Change committed as 271041

Powered by Google App Engine
This is Rietveld 408576698