third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js - Issue 2889013002: DevTools: introduce uiSourceCode.mimeType() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Issue 2889013002: DevTools: introduce uiSourceCode.mimeType() method (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js ('k') | third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

index 13db19a9cb4232de4c69aa65085ea0ed43863765..91fa9b0c9ab750f45739db8c9309617e36a428c2 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

@@ -356,14 +356,14 @@ Sources.SourcesView = class extends UI.VBox {

else if (contentType.isStyleSheet())

sourceFrame = new Sources.CSSSourceFrame(uiSourceCode);

else if (contentType === Common.resourceTypes.Image)

- sourceView = new SourceFrame.ImageView(Bindings.NetworkProject.uiSourceCodeMimeType(uiSourceCode), uiSourceCode);

+ sourceView = new SourceFrame.ImageView(uiSourceCode.mimeType(), uiSourceCode);

else if (contentType === Common.resourceTypes.Font)

- sourceView = new SourceFrame.FontView(Bindings.NetworkProject.uiSourceCodeMimeType(uiSourceCode), uiSourceCode);

+ sourceView = new SourceFrame.FontView(uiSourceCode.mimeType(), uiSourceCode);

else

sourceFrame = new SourceFrame.UISourceCodeFrame(uiSourceCode);

if (sourceFrame) {

- sourceFrame.setHighlighterType(Bindings.NetworkProject.uiSourceCodeMimeType(uiSourceCode));

+ sourceFrame.setHighlighterType(uiSourceCode.mimeType());

this._historyManager.trackSourceFrameCursorJumps(sourceFrame);

}

var widget = /** @type {!UI.Widget} */ (sourceFrame || sourceView);

@@ -402,7 +402,7 @@ Sources.SourcesView = class extends UI.VBox {

return;

var oldSourceFrame = /** @type {!SourceFrame.UISourceCodeFrame} */ (oldSourceView);

if (this._sourceFrameMatchesUISourceCode(oldSourceFrame, uiSourceCode)) {

- oldSourceFrame.setHighlighterType(Bindings.NetworkProject.uiSourceCodeMimeType(uiSourceCode));

+ oldSourceFrame.setHighlighterType(uiSourceCode.mimeType());

} else {

this._editorContainer.removeUISourceCode(uiSourceCode);

this._removeSourceFrame(uiSourceCode);