Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: content/browser/frame_host/navigation_handle_impl_browsertest.cc

Issue 2889003002: Change NavigationEntry to use virtual URL in error pages for blocked navigations (Closed)
Patch Set: Add a test for reload. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_handle_impl_browsertest.cc b/content/browser/frame_host/navigation_handle_impl_browsertest.cc
index 6f8d0334d29c5052a9d815272d94ffc884f253ae..5aee273bfbb28bc218916c7f3dc8aa38a6a18c80 100644
--- a/content/browser/frame_host/navigation_handle_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_handle_impl_browsertest.cc
@@ -1194,14 +1194,16 @@ IN_PROC_BROWSER_TEST_F(PlzNavigateNavigationHandleImplBrowserTest,
}
{
- // Reloading the page should not transfer processes.
- NavigationHandleObserver observer(shell()->web_contents(), blocked_url);
+ // Reloading the blocked document should load about:blank and not transfer
+ // processes.
+ GURL about_blank_url(url::kAboutBlankURL);
+ NavigationHandleObserver observer(shell()->web_contents(), about_blank_url);
TestNavigationObserver navigation_observer(shell()->web_contents(), 1);
shell()->Reload();
navigation_observer.Wait();
EXPECT_TRUE(observer.has_committed());
- EXPECT_TRUE(observer.is_error());
+ EXPECT_FALSE(observer.is_error());
EXPECT_EQ(site_instance,
shell()->web_contents()->GetMainFrame()->GetSiteInstance());
}

Powered by Google App Engine
This is Rietveld 408576698