Check that SVGImage is loaded in ImageNotifyFinished()

third_party/WebKit/Source/core/loader/ImageLoader.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010 Apple Inc. All rights
  * reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 537 matching lines @@
 
   image_complete_ = true;
   delay_until_image_notify_finished_ = nullptr;
 
   // Update ImageAnimationPolicy for image_.
   if (image_)
     image_->UpdateImageAnimationPolicy();
 
   UpdateLayoutObject();
 
-  if (image_ && image_->GetImage() && image_->GetImage()->IsSVGImage())
+  if (image_ && image_->GetImage() && image_->GetImage()->IsSVGImage()) {
+    ToSVGImage(image_->GetImage())->CheckLoaded();

[pdr., 2017/05/19 17:16:42]

Can you add a comment here describing why it would be dangerous for this to
fail? I'd just like to help a future engineer years from now who finds this line
and thinks it can be removed.

[hiroshige, 2017/05/19 20:51:44]

Added comments here and in CheckLoaded().
SVG people, do these comment look reasonable?

     ToSVGImage(image_->GetImage())
         ->UpdateUseCounters(GetElement()->GetDocument());
+  }
 
   if (loading_image_document_) {
     CHECK(!has_pending_load_event_);
     return;
   }
 
   CHECK(has_pending_load_event_);
 
   if (resource->ErrorOccurred()) {
     LoadEventSender().CancelEvent(this);
@@ skipping 148 matching lines @@
   }
   if (delay_until_image_notify_finished_) {
     delay_until_image_notify_finished_->DocumentChanged(
         element_->GetDocument());
   }
   ClearFailedLoadURL();
   ClearImage();
 }
 
 }  // namespace blink