Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2888953002: Analyzer: add ignore_for_file comment that ignores a type of problem for the whole file; add tests. (Closed)

Created:
3 years, 7 months ago by davidmorgan
Modified:
3 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Analyzer: add ignore_for_file comment that ignores a type of problem for the whole file; add tests. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/32c4094d04a239088c8a7daa2603295d600ff981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 6 chunks +38 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-05-17 16:50:04 UTC) #2
davidmorgan
3 years, 7 months ago (2017-05-18 08:18:44 UTC) #3
davidmorgan
3 years, 7 months ago (2017-05-19 08:02:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32c4094d04a239088c8a7daa2603295d600ff981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698