DevTools: fix race when revealing formatted source code

third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
index fcbd1ff86ce0263380e79eac3be2b58cd893935c..d3a083345e2d108952b538dbd55827415018c7c9 100644
--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
@@ -95,12 +95,8 @@ Coverage.CoverageListView = class extends UI.VBox {
       this._sortingChanged();
   }
 
-  /**
-   * @param {!Common.Event} event
-   */
-  _onOpenedNode(event) {
-    var node = /** @type Coverage.CoverageListView.GridNode */ (event.data);
-    this._revealSourceForNode(node);
+  _onOpenedNode() {
+    this._revealSourceForSelectedNode();
   }
 
   /**
@@ -118,13 +114,11 @@ Coverage.CoverageListView = class extends UI.VBox {
     if (!isEnterKey(event))
       return;
     event.consume(true);
-    this._revealSourceForNode(this._dataGrid.selectedNode);
+    this._revealSourceForSelectedNode();
   }
 
-  /**
-   * @param {?DataGrid.DataGridNode} node
-   */
-  async _revealSourceForNode(node) {
+  async _revealSourceForSelectedNode() {

[lushnikov, 2017/05/17 23:39:08]

is this change necessary?

[caseq, 2017/05/18 02:04:37]

This is not directly related, but seems like a reasonable drive-by -- we don't
want late "reveal" to be completed if user navigated away.

+    var node = this._dataGrid.selectedNode;
     if (!node)
       return;
     var coverageInfo = /** @type {!Coverage.CoverageListView.GridNode} */ (node)._coverageInfo;
@@ -134,10 +128,11 @@ Coverage.CoverageListView = class extends UI.VBox {
     var content = await sourceCode.requestContent();
     if (TextUtils.isMinified(content)) {
       var formatData = await Sources.sourceFormatter.format(sourceCode);

[lushnikov, 2017/05/17 23:39:08]

not: as per decision taken in performance-room, we now should put '// -----
ASYNC ------ comment before every await statement

[caseq, 2017/05/18 02:04:37]

Done.

-      Common.Revealer.reveal(formatData.formattedSourceCode);
-    } else {
-      Common.Revealer.reveal(sourceCode);
+      sourceCode = formatData.formattedSourceCode;
     }
+    if (this._dataGrid.selectedNode !== node)
+      return;
+    Common.Revealer.reveal(sourceCode);
   }
 
   _sortingChanged() {