Issue 2888833002: Force low resolution timers to see what tests fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2888833002: Force low resolution timers to see what tests fail

Created:
3 years, 7 months ago by brucedawson

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Force low resolution timers to see what tests fail Some tests fail with low resolution timers on Windows due to assumptions about timers returning different values just because a bit of time has passed. This test CL is designed to flush them out. This CL will not be landed. BUG=723225

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/time/time_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

brucedawson

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-17 02:15:26 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888833002/1

3 years, 7 months ago (2017-05-17 02:16:46 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 7 months ago (2017-05-17 07:58:25 UTC) #3

commit-bot: I haz the power

3 years, 7 months ago (2017-05-17 07:58:26 UTC) #4

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages