Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 288883004: Select the pointed item when drag operation starts. (Closed)

Created:
6 years, 7 months ago by fukino
Modified:
6 years, 7 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Select the pointed item when drag operation starts. What this CL do: If there is an item at the drag's starting position and the item is not selected, select the item. Why this handling is needed: If the drag operation is initiated by mouse, the 'mousedown' event eventually selects the pointed item, but there is no such chance when the drag operation is initiated by touch. BUG=373839 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ui/webui/resources/js/cr/ui/list.js View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fukino
Hi @arv, I'd like to add one more handling for touch operation in the cr.ui.List. ...
6 years, 7 months ago (2014-05-19 11:24:32 UTC) #1
arv (Not doing code reviews)
Why isn't the item selected before the dragstart event? Is it because we are not ...
6 years, 7 months ago (2014-05-19 18:14:10 UTC) #2
fukino
On 2014/05/19 18:14:10, arv wrote: > Why isn't the item selected before the dragstart event? ...
6 years, 7 months ago (2014-05-19 23:42:18 UTC) #3
arv (Not doing code reviews)
LGTM Thanks for explaining.
6 years, 7 months ago (2014-05-20 00:31:30 UTC) #4
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-20 00:39:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/288883004/1
6 years, 7 months ago (2014-05-20 00:40:49 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 02:07:25 UTC) #7
Message was sent while issue was closed.
Change committed as 271535

Powered by Google App Engine
This is Rietveld 408576698