Remove async modifier from outlines

Remove async modifier from outlines

In the future we might want to re-add this, but for now, no one needs to know
that a function was async/async*/sync*. This also allows the async/await
transformer to ignore external references without any special logic.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ebfd044456540aa26a0bf1bc211ce058ca1c9c52

[Siggi Cherem (dart-lang), 2017-05-18 19:44:00]

sigmund@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com, scheglov@google.com

[Siggi Cherem (dart-lang), 2017-05-18 19:44:04]

https://codereview.chromium.org/2888823004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart (right):

https://codereview.chromium.org/2888823004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart:225:
function.dartAsyncMarker = actualAsyncModifier;
Note: when `function` is created we will pass AsyncModifier.Sync, and it gets
copied into dartAsyncMarker. Now that we are changing the value later in time,
we need to also update the secondary location as well.

https://codereview.chromium.org/2888823004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/outline_builder.dart (left):

https://codereview.chromium.org/2888823004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/outline_builder.dart:48: AsyncMarker
asyncMarkerFromTokens(Token asyncToken, Token starToken) {
this now only used by body_builder, so I moved it there.

[scheglov, 2017-05-18 21:38:56]

LGTM

[Siggi Cherem (dart-lang), 2017-05-18 22:20:28]

Description was changed from

==========
Remove async modifier from outlines

In the future we might want to re-add this, but for now, no one needs to know
that a function was async/async*/sync*. This also allows the async/await
transformer to ignore external references without any special logic.
==========

to

==========
Remove async modifier from outlines

In the future we might want to re-add this, but for now, no one needs to know
that a function was async/async*/sync*. This also allows the async/await
transformer to ignore external references without any special logic.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ebfd044456540aa26a0bf1bc211ce058ca1c9c52
==========

[Siggi Cherem (dart-lang), 2017-05-18 22:20:29]

Committed patchset #1 (id:1) manually as
ebfd044456540aa26a0bf1bc211ce058ca1c9c52 (presubmit successful).

[ahe, 2017-05-22 13:34:15]

lgtm