Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(332)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/select.html
Issue
2888803002
:
Handle WebContentsViewMac being destroyed while a <select> menu is showing. (Closed)
Patch Set: respond to comments
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/ui/cocoa/tab_contents/web_contents_view_mac_interactive_uitest.mm
chrome/test/BUILD.gn
chrome/test/data/select.html
content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h
content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm
content/browser/frame_host/popup_menu_helper_mac.h
content/browser/frame_host/popup_menu_helper_mac.mm
content/browser/web_contents/web_contents_view_mac.h
content/browser/web_contents/web_contents_view_mac.mm
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/BUILD.gn
('k') |
content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<html>
3
<body>
4
<select>
5
<option selected>Apple</option>
6
<option>Orange</option>
7
<option>Banana</option>
8
</select>
9
<script>
10
document.querySelector('select').focus();
11
</script>
12
</body>
13
</html>
OLD
NEW
« no previous file with comments
|
« chrome/test/BUILD.gn
('k') |
content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h »
('j') |
no next file with comments »
Issue 2888803002: Handle WebContentsViewMac being destroyed while a <select> menu is showing. (Closed)
Created 3 years, 7 months ago by tapted
Modified 3 years, 7 months ago
Reviewers: Avi (use Gerrit)
Base URL:
Comments: 6
This is Rietveld
408576698