Do not create CRWWebUIManager for non-WebUI URLs.

ios/web/web_state/ui/crw_web_controller.mm

Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 8b17115ffff239e137ea52f7dc8c6d7228fe2a37..ad8548576fb6c009b2401a09d2474874e85e80de 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -3162,9 +3162,13 @@ registerLoadRequestForURL:(const GURL&)requestURL
 #pragma mark WebUI
 
 - (void)createWebUIForURL:(const GURL&)URL {
+  // |CreateWebUI| will do nothing if |URL| is not a WebUI URL.

[michaeldo, 2017/05/17 15:17:31]

Can you add to this something like "but must be called before checking
HasWebUI()" below"? I was going to suggest that CreateWebUI be moved into the if
statement, but I believe it must be called before HasWebUI will return the
correct value and it isn't intuitive.

[Eugene But (OOO till 7-30), 2017/05/17 18:36:41]

Updated comment.

   _webStateImpl->CreateWebUI(URL);
-  _webUIManager.reset(
-      [[CRWWebUIManager alloc] initWithWebState:self.webStateImpl]);
+  bool isWebUIURL = _webStateImpl->HasWebUI();
+  if (isWebUIURL) {
+    _webUIManager.reset(
+        [[CRWWebUIManager alloc] initWithWebState:_webStateImpl]);
+  }
 }
 
 - (void)clearWebUI {
@@ -4118,6 +4122,7 @@ registerLoadRequestForURL:(const GURL&)requestURL
 }
 
 - (void)loadHTML:(NSString*)HTML forURL:(const GURL&)URL {
+  DCHECK(HTML.length);

[michaeldo, 2017/05/17 15:17:31]

Should we add a note to the comment for this method that |HTML| must not be
empty?

[Eugene But (OOO till 7-30), 2017/05/17 18:36:41]

Done.

   // Remove the transient content view.
   [self clearTransientContentView];