Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2888773003: Do not create CRWWebUIManager for non-WebUI URLs. (Closed)
Patch Set: Self review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 8b17115ffff239e137ea52f7dc8c6d7228fe2a37..9305032c93f290ed5434963b050f892a75c48b93 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -3163,8 +3163,11 @@ registerLoadRequestForURL:(const GURL&)requestURL
- (void)createWebUIForURL:(const GURL&)URL {
_webStateImpl->CreateWebUI(URL);
PL 2017/05/17 00:04:26 For chrome://crash we would still run CreateWebUI
Eugene But (OOO till 7-30) 2017/05/17 14:49:26 That should not be a problem. Added explanation co
- _webUIManager.reset(
- [[CRWWebUIManager alloc] initWithWebState:self.webStateImpl]);
+ bool isWebUIURL = _webStateImpl->HasWebUI();
+ if (isWebUIURL) {
+ _webUIManager.reset(
+ [[CRWWebUIManager alloc] initWithWebState:_webStateImpl]);
+ }
}
- (void)clearWebUI {
@@ -4118,6 +4121,7 @@ registerLoadRequestForURL:(const GURL&)requestURL
}
- (void)loadHTML:(NSString*)HTML forURL:(const GURL&)URL {
+ DCHECK(HTML.length);
// Remove the transient content view.
[self clearTransientContentView];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698