remoting/host/security_key/security_key_ipc_client.cc - Issue 2888733002: Adding ThreadChecker validation to d'tors for host classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/security_key/security_key_ipc_client.cc

Issue 2888733002: Adding ThreadChecker validation to d'tors for host classes (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/security_key/security_key_ipc_client.cc

diff --git a/remoting/host/security_key/security_key_ipc_client.cc b/remoting/host/security_key/security_key_ipc_client.cc

index 3b6b4058374725d8bf890fc08ed00db54fadd4eb..c2df6e266017b01af364436c70ebb906216bd6ce 100644

--- a/remoting/host/security_key/security_key_ipc_client.cc

+++ b/remoting/host/security_key/security_key_ipc_client.cc

@@ -26,7 +26,9 @@ SecurityKeyIpcClient::SecurityKeyIpcClient()

: named_channel_handle_(remoting::GetSecurityKeyIpcChannel()),

weak_factory_(this) {}

-SecurityKeyIpcClient::~SecurityKeyIpcClient() {}

+SecurityKeyIpcClient::~SecurityKeyIpcClient() {

+ DCHECK(thread_checker_.CalledOnValidThread());

bool SecurityKeyIpcClient::CheckForSecurityKeyIpcServerChannel() {

DCHECK(thread_checker_.CalledOnValidThread());