remoting/host/security_key/security_key_auth_handler_win.cc - Issue 2888733002: Adding ThreadChecker validation to d'tors for host classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/security_key/security_key_auth_handler_win.cc

Issue 2888733002: Adding ThreadChecker validation to d'tors for host classes (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/security_key/security_key_auth_handler_win.cc

diff --git a/remoting/host/security_key/security_key_auth_handler_win.cc b/remoting/host/security_key/security_key_auth_handler_win.cc

index 55d72feb2bcd92512ce019676d0f94646f7be818..4f89fed7e75341127fc95421e78a9aad0451a5dd 100644

--- a/remoting/host/security_key/security_key_auth_handler_win.cc

+++ b/remoting/host/security_key/security_key_auth_handler_win.cc

@@ -127,7 +127,9 @@ SecurityKeyAuthHandlerWin::SecurityKeyAuthHandlerWin(

DCHECK(client_session_details_);

}

-SecurityKeyAuthHandlerWin::~SecurityKeyAuthHandlerWin() {}

+SecurityKeyAuthHandlerWin::~SecurityKeyAuthHandlerWin() {

+ DCHECK(thread_checker_.CalledOnValidThread());

void SecurityKeyAuthHandlerWin::CreateSecurityKeyConnection() {

DCHECK(thread_checker_.CalledOnValidThread());