Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Side by Side Diff: build/android/pylib/results/presentation/javascript/main_html.js

Issue 2888723002: Make the table cells clickable, instead of the strings inside. (Closed)
Patch Set: address Yoland's comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/pylib/results/presentation/template/main.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 function getArguments() { 5 function getArguments() {
6 // Returns the URL arguments as a dictionary. 6 // Returns the URL arguments as a dictionary.
7 args = {} 7 args = {}
8 var s = location.search; 8 var s = location.search;
9 if (s) { 9 if (s) {
10 var vals = s.substring(1).split('&'); 10 var vals = s.substring(1).split('&');
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 }); 184 });
185 185
186 for (var i = 0; i < rowBlocks.length; i++) { 186 for (var i = 0; i < rowBlocks.length; i++) {
187 table.appendChild(rowBlocks[i]); 187 table.appendChild(rowBlocks[i]);
188 } 188 }
189 } 189 }
190 190
191 function sortSuiteTableByFailedTestCases() { 191 function sortSuiteTableByFailedTestCases() {
192 sortByColumn(document.getElementById('number_fail_tests')); 192 sortByColumn(document.getElementById('number_fail_tests'));
193 } 193 }
194
195 function setTableCellsAsClickable() {
196 const tableCells = document.getElementsByTagName('td');
197 for(let i = 0; i < tableCells.length; i++) {
198 const links = tableCells[i].getElementsByTagName('a');
199 // Only make the cell clickable if there is only one link.
200 if (links.length == 1) {
201 tableCells[i].addEventListener('click', function() {
202 links[0].click();
203 });
204 tableCells[i].addEventListener('mouseover', function() {
205 tableCells[i].style.cursor = 'pointer';
206 links[0].style.textDecoration = 'underline';
207 });
208 tableCells[i].addEventListener('mouseout', function() {
209 tableCells[i].style.cursor = 'initial';
210 links[0].style.textDecoration = 'initial';
211 });
212 }
213 }
214 }
OLDNEW
« no previous file with comments | « no previous file | build/android/pylib/results/presentation/template/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698