Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2888653005: Fix declaration of GenericTypeAliasElementForLink. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix declaration of GenericTypeAliasElementForLink. This class needs to implement FunctionTypeAliasElementForLink so that it can be stored in CompilationUnitElementForLink._functionTypeAliases (and returned by CompilationUnitElementForLink.functionTypeAliases) without incurring checked mode errors. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6866291fb386f1e4d77d8dcf7c2208f15c7b8313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-17 20:57:20 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-17 20:58:41 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 6866291fb386f1e4d77d8dcf7c2208f15c7b8313 (presubmit successful).
3 years, 7 months ago (2017-05-17 21:03:51 UTC) #5
Brian Wilkerson
3 years, 7 months ago (2017-05-17 21:42:37 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698