Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2888653003: increase bucket size and break down video by http/https (Closed)
Patch Set: Final formatting fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a6c8a40315f2d39a7793014058f5c79aa2e3152b..7e90fffda290073b37c32610e307cefee4751f7d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -89397,12 +89397,45 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram_suffixes>
<histogram_suffixes name="NetHttpContentLengthType" separator=".">
- <suffix name="Http"/>
- <suffix name="Https"/>
- <suffix name="Video"/>
+ <suffix name="Http">
+ <obsolete>
RyanSturm 2017/05/24 23:15:37 Don't obsolete Http or Https?
ajo1 2017/05/25 18:19:09 They shouldn't be used without the suffix.
RyanSturm 2017/05/25 21:05:41 Good point. isherman@ does that seem right?
Ilya Sherman 2017/05/25 22:12:31 Yep, this seems reasonable =)
+ Replaced by HttpContentLength Direct/ViaDRP variants.
+ </obsolete>
+ </suffix>
+ <suffix name="Https">
+ <obsolete>
+ Replaced by HttpContentLength Direct/ViaDRP variants.
+ </obsolete>
+ </suffix>
+ <suffix name="Video">
+ <obsolete>
+ Replaced by HttpContentLength Direct/ViaDRP variants.
+ </obsolete>
+ </suffix>
<affected-histogram name="Net.HttpContentLength"/>
</histogram_suffixes>
+<histogram_suffixes name="NetHttpContentLengthType2" separator=".">
+ <suffix name="BypassedDRP"/>
+ <suffix name="Direct"/>
+ <suffix name="Other"/>
+ <suffix name="ViaDRP"/>
+ <affected-histogram name="Net.HttpContentLength.Http"/>
+ <affected-histogram name="Net.HttpContentLength.Https"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="NetHttpContentLengthType3" separator=".">
+ <suffix name="Video"/>
+ <affected-histogram name="Net.HttpContentLength.Http.BypassedDRP"/>
+ <affected-histogram name="Net.HttpContentLength.Http.Direct"/>
+ <affected-histogram name="Net.HttpContentLength.Http.Other"/>
+ <affected-histogram name="Net.HttpContentLength.Http.ViaDRP"/>
+ <affected-histogram name="Net.HttpContentLength.Https.BypassedDRP"/>
+ <affected-histogram name="Net.HttpContentLength.Https.Direct"/>
+ <affected-histogram name="Net.HttpContentLength.Https.Other"/>
+ <affected-histogram name="Net.HttpContentLength.Https.ViaDRP"/>
+</histogram_suffixes>
+
<histogram_suffixes name="NetHttpProxyConnectLatencySecure" separator=".">
<owner>tbansal@chromium.org</owner>
<suffix name="Insecure" label="Insecure proxy"/>

Powered by Google App Engine
This is Rietveld 408576698