tools/metrics/histograms/histograms.xml - Issue 2888653003: increase bucket size and break down video by http/https

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2888653003: increase bucket size and break down video by http/https (Closed)

Patch Set: review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index a6c8a40315f2d39a7793014058f5c79aa2e3152b..7e90fffda290073b37c32610e307cefee4751f7d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -89397,12 +89397,45 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram_suffixes>

<histogram_suffixes name="NetHttpContentLengthType" separator=".">

- <suffix name="Http"/>

- <suffix name="Https"/>

- <suffix name="Video"/>

+ <suffix name="Http">

+ <obsolete>

+ Replaced by HttpContentLength Direct/ViaDRP variants.

+ </obsolete>

+ </suffix>

+ <suffix name="Https">

+ <obsolete>

+ Replaced by HttpContentLength Direct/ViaDRP variants.

+ </obsolete>

+ </suffix>

+ <suffix name="Video">

+ <obsolete>

+ Replaced by HttpContentLength Direct/ViaDRP variants.

+ </obsolete>

+ </suffix>

<affected-histogram name="Net.HttpContentLength"/>

</histogram_suffixes>

+<histogram_suffixes name="NetHttpContentLengthType2" separator=".">

+ <suffix name="BypassedDRP"/>

+ <suffix name="Direct"/>

+ <suffix name="Other"/>

+ <suffix name="ViaDRP"/>

Ilya Sherman 2017/05/25 22:12:32 Please add a brief label for each suffix.

+ <affected-histogram name="Net.HttpContentLength.Http"/>

+ <affected-histogram name="Net.HttpContentLength.Https"/>

+</histogram_suffixes>

+<histogram_suffixes name="NetHttpContentLengthType3" separator=".">

+ <suffix name="Video"/>

+ <affected-histogram name="Net.HttpContentLength.Http.BypassedDRP"/>

+ <affected-histogram name="Net.HttpContentLength.Http.Direct"/>

+ <affected-histogram name="Net.HttpContentLength.Http.Other"/>

+ <affected-histogram name="Net.HttpContentLength.Http.ViaDRP"/>

+ <affected-histogram name="Net.HttpContentLength.Https.BypassedDRP"/>

+ <affected-histogram name="Net.HttpContentLength.Https.Direct"/>

+ <affected-histogram name="Net.HttpContentLength.Https.Other"/>

+ <affected-histogram name="Net.HttpContentLength.Https.ViaDRP"/>

+</histogram_suffixes>

<histogram_suffixes name="NetHttpProxyConnectLatencySecure" separator=".">

<owner>tbansal@chromium.org</owner>