Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 288863004: Add a strict mode for gclient DEPS parsing, to enable saner parsing constraints. (Closed)

Created:
6 years, 7 months ago by iannucci
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add a strict mode for gclient DEPS parsing, to enable saner parsing constraints. R=agable@chromium.org, mmoss@chromium.org, szager@chromium.org BUG=366925 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=272033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M gclient.py View 2 chunks +31 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
6 years, 7 months ago (2014-05-21 23:38:12 UTC) #1
Michael Moss
lgtm
6 years, 7 months ago (2014-05-22 00:11:33 UTC) #2
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 7 months ago (2014-05-22 00:26:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/288863004/1
6 years, 7 months ago (2014-05-22 00:27:29 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 00:29:23 UTC) #5
Message was sent while issue was closed.
Change committed as 272033

Powered by Google App Engine
This is Rietveld 408576698