Delete panel metrics and define insets in terms of distance metrics.

ui/views/layout/grid_layout.cc

Index: ui/views/layout/grid_layout.cc
diff --git a/ui/views/layout/grid_layout.cc b/ui/views/layout/grid_layout.cc
index 7a713dd502e5727e2a9b44e33e0b15f70454b954..b3b82abb5b4d50f95d82f97c0c89c51b36d50f63 100644
--- a/ui/views/layout/grid_layout.cc
+++ b/ui/views/layout/grid_layout.cc
@@ -653,8 +653,8 @@ GridLayout::~GridLayout() {
 // static
 GridLayout* GridLayout::CreatePanel(View* host) {

[sky, 2017/05/18 16:39:24]

I'm ok with this change, but WDYT of removing this function in favor of callers
creating an explicit function.

[Peter Kasting, 2017/05/18 16:46:46]

What does "callers creating an explicit function" mean?

Like, a helper at each callsite?  We have a lot.  In fact the lack of a global
convenience function like this for fill/boxlayout is something we've been
tripping over and may want to fix.  Not sure the best way to do it.

   GridLayout* layout = new GridLayout(host);
-  host->SetBorder(
-      CreateEmptyBorder(LayoutProvider::Get()->GetInsetsMetric(INSETS_PANEL)));
+  host->SetBorder(CreateEmptyBorder(
+      LayoutProvider::Get()->GetInsetsMetric(INSETS_DIALOG_CONTENTS)));
   host->SetLayoutManager(layout);
   return layout;
 }