Delete panel metrics and define insets in terms of distance metrics.

chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
index 56cd08fd8e1c1197ca970df441775293e229b895..5d38c6b6a1c95870d60bd3716a2b9fd246fc545d 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
@@ -135,11 +135,14 @@ AppInfoDialog::AppInfoDialog(gfx::NativeWindow parent_window,
   // Make a vertically stacked view of all the panels we want to display in the
   // dialog.
   views::View* dialog_body_contents = new views::View();
+  const ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
   dialog_body_contents->SetLayoutManager(new views::BoxLayout(
-      views::BoxLayout::kVertical, views::kButtonHEdgeMarginNew,
-      ChromeLayoutProvider::Get()->GetDistanceMetric(
-          DISTANCE_PANEL_CONTENT_MARGIN),
-      views::kUnrelatedControlVerticalSpacing));
+      views::BoxLayout::kVertical,
+      provider->GetDistanceMetric(
+          views::DISTANCE_DIALOG_CONTENTS_HORIZONTAL_MARGIN),

[Peter Kasting, 2017/05/18 00:00:06]

One of a number of places in the codebase where it would probably make sense to
have a helper function in BoxLayout a la GridLayout::CreatePanel() that
constructs some new box layout and puts the correct dialog margins around the
edge.

Doesn't need to be done in this CL.

[Bret, 2017/05/18 00:50:05]

Yes, that seems like a good idea. It'll be even easier when we remove a bunch of
these weird distinctions we're making just because they're arbitrarily different
pre-Harmony.

+      provider->GetDistanceMetric(
+          views::DISTANCE_DIALOG_CONTENTS_VERTICAL_MARGIN),
+      provider->GetDistanceMetric(DISTANCE_UNRELATED_CONTROL_VERTICAL)));
   dialog_body_contents->AddChildView(new AppInfoSummaryPanel(profile, app));
   dialog_body_contents->AddChildView(new AppInfoPermissionsPanel(profile, app));