Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3622)

Unified Diff: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)
Patch Set: one wrong conversion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
index 4315eba621e7401166b7259694ab53a03398c787..a4d5ad23b5e17ec2c13f5492912a0a42f09a2bdf 100644
--- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
@@ -198,12 +198,13 @@ void ProfileSigninConfirmationDialogViews::ViewHierarchyChanged(
views::StyledLabel::RangeStyleInfo::CreateForLink());
// Layout the components.
- const gfx::Insets panel_insets =
- views::LayoutProvider::Get()->GetInsetsMetric(views::INSETS_PANEL);
- // The prompt bar needs to go to the edge of the dialog, so ignore insets for
- // the outer layout.
- SetBorder(views::CreateEmptyBorder(panel_insets.top(), 0,
- panel_insets.bottom(), 0));
+ const gfx::Insets content_insets =
+ views::LayoutProvider::Get()->GetInsetsMetric(
+ views::INSETS_DIALOG_CONTENTS);
+ // The prompt bar needs to go to the edge of the dialog, so remove horizontal
+ // insets.
+ SetBorder(views::CreateEmptyBorder(content_insets.top(), 0,
+ content_insets.bottom(), 0));
views::GridLayout* dialog_layout = new views::GridLayout(this);
SetLayoutManager(dialog_layout);
@@ -225,15 +226,15 @@ void ProfileSigninConfirmationDialogViews::ViewHierarchyChanged(
views::GridLayout::FILL, views::GridLayout::FILL, 0, 0);
// Use a new column set for the explanation label so we can add padding.
- dialog_layout->AddPaddingRow(0.0, panel_insets.top());
+ dialog_layout->AddPaddingRow(0.0, content_insets.top());
constexpr int kExplanationColumnSetId = 1;
views::ColumnSet* explanation_columns =
dialog_layout->AddColumnSet(kExplanationColumnSetId);
- explanation_columns->AddPaddingColumn(0.0, panel_insets.left());
+ explanation_columns->AddPaddingColumn(0.0, content_insets.left());
explanation_columns->AddColumn(
views::GridLayout::FILL, views::GridLayout::FILL, 100,
views::GridLayout::USE_PREF, 0, 0);
- explanation_columns->AddPaddingColumn(0.0, panel_insets.right());
+ explanation_columns->AddPaddingColumn(0.0, content_insets.right());
dialog_layout->StartRow(0, kExplanationColumnSetId);
const int kPreferredWidth = 440;
dialog_layout->AddView(explanation_label, 1, 1, views::GridLayout::FILL,
« no previous file with comments | « chrome/browser/ui/views/settings_reset_prompt_dialog.cc ('k') | chrome/browser/ui/views/task_manager_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698