chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc - Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)

Patch Set: one wrong conversion Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc ('k') | chrome/browser/ui/views/harmony/chrome_layout_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

index 7ce2ab453dbde6e3c47053e972dcdf98d8a76e81..56056320e0f2618537cefd2c48af9dda1b9a92a9 100644

--- a/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

@@ -86,7 +86,8 @@ gfx::Size RequestFileSystemDialogView::GetPreferredSize() const {

}

gfx::Insets RequestFileSystemDialogView::GetInsets() const {

- return ChromeLayoutProvider::Get()->GetInsetsMetric(views::INSETS_PANEL);

+ return ChromeLayoutProvider::Get()->GetInsetsMetric(

+ views::INSETS_DIALOG_CONTENTS);

}

RequestFileSystemDialogView::RequestFileSystemDialogView(