chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc - Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)

Patch Set: one wrong conversion Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/cookie_info_view.cc ('k') | chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

index 54d69003c22a4c2f81e5fa2b8de3b9c0dc58ed54..3497c26b73f46ecf078130be20bd6cef88745be4 100644

--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

@@ -64,13 +64,15 @@ DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(

description_label_(new views::Label()),

audio_share_checkbox_(nullptr),

pane_(new views::TabbedPane()) {

- ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();

+ const ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();

SetLayoutManager(new views::BoxLayout(

views::BoxLayout::kVertical,

- provider->GetDistanceMetric(DISTANCE_DIALOG_BUTTON_MARGIN),

- provider->GetDistanceMetric(DISTANCE_PANEL_CONTENT_MARGIN),

- provider->GetDistanceMetric(views::DISTANCE_RELATED_CONTROL_VERTICAL)));

+ provider->GetDistanceMetric(

+ views::DISTANCE_DIALOG_CONTENTS_HORIZONTAL_MARGIN),

+ provider->GetDistanceMetric(

+ views::DISTANCE_DIALOG_CONTENTS_VERTICAL_MARGIN),

+ provider->GetDistanceMetric(DISTANCE_RELATED_CONTROL_VERTICAL_SMALL)));

description_label_->SetMultiLine(true);

description_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);