Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)
Patch Set: one wrong conversion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/arc_app_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
index 56cd08fd8e1c1197ca970df441775293e229b895..5d38c6b6a1c95870d60bd3716a2b9fd246fc545d 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
@@ -135,11 +135,14 @@ AppInfoDialog::AppInfoDialog(gfx::NativeWindow parent_window,
// Make a vertically stacked view of all the panels we want to display in the
// dialog.
views::View* dialog_body_contents = new views::View();
+ const ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
dialog_body_contents->SetLayoutManager(new views::BoxLayout(
- views::BoxLayout::kVertical, views::kButtonHEdgeMarginNew,
- ChromeLayoutProvider::Get()->GetDistanceMetric(
- DISTANCE_PANEL_CONTENT_MARGIN),
- views::kUnrelatedControlVerticalSpacing));
+ views::BoxLayout::kVertical,
+ provider->GetDistanceMetric(
+ views::DISTANCE_DIALOG_CONTENTS_HORIZONTAL_MARGIN),
+ provider->GetDistanceMetric(
+ views::DISTANCE_DIALOG_CONTENTS_VERTICAL_MARGIN),
+ provider->GetDistanceMetric(DISTANCE_UNRELATED_CONTROL_VERTICAL)));
dialog_body_contents->AddChildView(new AppInfoSummaryPanel(profile, app));
dialog_body_contents->AddChildView(new AppInfoPermissionsPanel(profile, app));
« no previous file with comments | « no previous file | chrome/browser/ui/views/arc_app_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698