Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: chrome/browser/ui/views/harmony/chrome_layout_provider.h

Issue 2888563004: Delete panel metrics and define insets in terms of distance metrics. (Closed)
Patch Set: one wrong conversion Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_ 6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "ui/gfx/geometry/insets.h" 11 #include "ui/gfx/geometry/insets.h"
12 #include "ui/views/layout/grid_layout.h" 12 #include "ui/views/layout/grid_layout.h"
13 #include "ui/views/layout/layout_provider.h" 13 #include "ui/views/layout/layout_provider.h"
14 14
15 enum ChromeDistanceMetric { 15 enum ChromeDistanceMetric {
16 // Default minimum width of a button. 16 // Default minimum width of a button.
17 DISTANCE_BUTTON_MINIMUM_WIDTH = views::VIEWS_DISTANCE_END, 17 DISTANCE_BUTTON_MINIMUM_WIDTH = views::VIEWS_DISTANCE_END,
18 // Vertical spacing between a list of multiple controls in one column. 18 // Vertical spacing between a list of multiple controls in one column.
19 DISTANCE_CONTROL_LIST_VERTICAL, 19 DISTANCE_CONTROL_LIST_VERTICAL,
20 // Margin between the edge of a dialog and the left, right, or bottom of a
21 // contained button.
22 DISTANCE_DIALOG_BUTTON_MARGIN,
23 // Spacing between a dialog button and the content above it. 20 // Spacing between a dialog button and the content above it.
24 DISTANCE_DIALOG_BUTTON_TOP, 21 DISTANCE_DIALOG_BUTTON_TOP,
25 // Horizontal or vertical margin between the edge of a panel and the
26 // contained content.
27 DISTANCE_PANEL_CONTENT_MARGIN,
28 // Smaller horizontal spacing between other controls that are logically 22 // Smaller horizontal spacing between other controls that are logically
29 // related. 23 // related.
30 DISTANCE_RELATED_CONTROL_HORIZONTAL_SMALL, 24 DISTANCE_RELATED_CONTROL_HORIZONTAL_SMALL,
31 // Smaller vertical spacing between controls that are logically related. 25 // Smaller vertical spacing between controls that are logically related.
32 DISTANCE_RELATED_CONTROL_VERTICAL_SMALL, 26 DISTANCE_RELATED_CONTROL_VERTICAL_SMALL,
33 // Horizontal spacing between an item such as an icon or checkbox and a 27 // Horizontal spacing between an item such as an icon or checkbox and a
34 // label related to it. 28 // label related to it.
35 DISTANCE_RELATED_LABEL_HORIZONTAL, 29 DISTANCE_RELATED_LABEL_HORIZONTAL,
36 // Horizontal indent of a subsection relative to related items above, e.g. 30 // Horizontal indent of a subsection relative to related items above, e.g.
37 // checkboxes below explanatory text/headings. 31 // checkboxes below explanatory text/headings.
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 // types, e.g. by adding a new LayoutDistance value that means what you need. 74 // types, e.g. by adding a new LayoutDistance value that means what you need.
81 // 75 //
82 // TODO(pkasting): Fix callers and remove this. 76 // TODO(pkasting): Fix callers and remove this.
83 virtual bool IsHarmonyMode() const; 77 virtual bool IsHarmonyMode() const;
84 78
85 private: 79 private:
86 DISALLOW_COPY_AND_ASSIGN(ChromeLayoutProvider); 80 DISALLOW_COPY_AND_ASSIGN(ChromeLayoutProvider);
87 }; 81 };
88 82
89 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_ 83 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698