Manage registering composited elements in PaintArtifactCompositor.

cc/layers/layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 106 matching lines @@
 }
 
 void Layer::SetLayerTreeHost(LayerTreeHost* host) {
   if (layer_tree_host_ == host)
     return;
 
   if (layer_tree_host_) {
     layer_tree_host_->property_trees()->RemoveIdFromIdToIndexMaps(id());
     layer_tree_host_->property_trees()->needs_rebuild = true;
     layer_tree_host_->UnregisterLayer(this);
-    if (inputs_.element_id) {
+    bool use_layer_lists = layer_tree_host_->GetSettings().use_layer_lists;
+    if (!use_layer_lists && inputs_.element_id) {
       layer_tree_host_->UnregisterElement(inputs_.element_id,
                                           ElementListType::ACTIVE, this);
     }
   }
   if (host) {
     host->property_trees()->needs_rebuild = true;
     host->RegisterLayer(this);
-    if (inputs_.element_id) {
+    bool use_layer_lists = host->GetSettings().use_layer_lists;
+    if (!use_layer_lists && inputs_.element_id) {
       host->RegisterElement(inputs_.element_id, ElementListType::ACTIVE, this);
     }
   }
 
   layer_tree_host_ = host;
   InvalidatePropertyTreesIndices();
 
   // When changing hosts, the layer needs to commit its properties to the impl
   // side for the new host.
   SetNeedsPushProperties();
 
   for (size_t i = 0; i < inputs_.children.size(); ++i)
     inputs_.children[i]->SetLayerTreeHost(host);
 
   if (inputs_.mask_layer.get())
     inputs_.mask_layer->SetLayerTreeHost(host);
 
-  const bool has_any_animation =
-      layer_tree_host_ ? GetMutatorHost()->HasAnyAnimation(element_id())
-                       : false;
-
-  if (host && has_any_animation)
-    host->SetNeedsCommit();
+  bool use_layer_lists =
+      layer_tree_host_ && layer_tree_host_->GetSettings().use_layer_lists;
+  if (!use_layer_lists) {

[pdr., 2017/05/16 02:46:35]

can this be simplified like:
if (host && host->GetSettings().use_layer_lists) {
  if (GetMutatorHost()->HasAnyAnimation(element_id()))
    host->SetNeedsCommit();
}

[wkorman, 2017/05/16 21:42:42]

Done and combined the two if's into one with an add'l &.

+    const bool has_any_animation =
+        layer_tree_host_ ? GetMutatorHost()->HasAnyAnimation(element_id())
+                         : false;
+    if (host && has_any_animation)
+      host->SetNeedsCommit();
+  }
 }
 
 void Layer::SetNeedsCommit() {
   if (!layer_tree_host_)
     return;
 
   SetNeedsPushProperties();
 
   if (ignore_set_needs_commit_)
     return;
@@ skipping 1255 matching lines @@
       ->subtree_has_copy_request;
 }
 
 gfx::Transform Layer::ScreenSpaceTransform() const {
   DCHECK_NE(transform_tree_index_, TransformTree::kInvalidNodeId);
   return draw_property_utils::ScreenSpaceTransform(
       this, layer_tree_host_->property_trees()->transform_tree);
 }
 
 }  // namespace cc