Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2888473003: [subresource_filter] Site Details UI for default state (Closed)
Patch Set: raymes review: remove some strings Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index 8e677fb2f37e865a657bc8e51e62f3e2c9f1f023..caab58f6a7c618a575198377d35f3b8b12a9bb8b 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -750,6 +750,12 @@ Your Google account may have other forms of browsing history like searches and a
<message name="IDS_SUBRESOURCE_FILTER_PERMISSION_TITLE" desc="Title for the subresource filter permission [CHAR-LIMIT=32]" translateable="false">
Subresource Filter
</message>
+ <message name="IDS_SUBRESOURCE_FILTER_PERMISSION_BLOCK" desc="The Blocked string for the subresource filter permission" translateable="false">
+ Block (subresource filter)
+ </message>
+ <message name="IDS_SUBRESOURCE_FILTER_PERMISSION_EXTRA_INFO" desc="The extra information at the top of the Site Details page when subresource filtering is activated" translateable="false">
Finnur 2017/05/23 15:37:13 nit: redundant space before translateable="false"
Charlie Harrison 2017/05/23 17:12:19 Done.
+ Subresource filtering activated on this page
Finnur 2017/05/23 15:37:13 As discussed before, we need better strings to exp
Charlie Harrison 2017/05/23 17:12:19 Acknowledged.
+ </message>
<message name="IDS_PUSH_NOTIFICATIONS_PERMISSION_TITLE" desc="Title for the permission for showing push notifications [CHAR-LIMIT=32]">
Notifications
</message>

Powered by Google App Engine
This is Rietveld 408576698