[subresource_filter] Site Details UI for default state

chrome/android/java/res/xml/single_website_preferences.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
     <org.chromium.chrome.browser.preferences.ChromeBasePreference
         android:key="os_permissions_warning" />
     <org.chromium.chrome.browser.preferences.ChromeBasePreference
         android:key="os_permissions_warning_extra" />
     <Preference
         android:key="os_permissions_warning_divider"
         android:layout="@layout/divider_preference" />
+    <org.chromium.chrome.browser.preferences.ChromeBasePreference
+        android:key="website_settings_extra_info"
+        android:icon="@drawable/btn_info" />
+    <Preference
+        android:key="website_settings_extra_info_divider"
+        android:layout="@layout/divider_preference" />

[Finnur, 2017/05/23 15:37:13]

I think it would lessen the cognitive overload for the user (and potentially
code complexity for us devs also) if this was a simple subtitle under the
subresource_filter_permission_list preference. I think that was the original
intent of the designer and we should explore that option, unless someone
objects.

A secondary, and perhaps moot concern, is that a preference might not be the
best widget to use to show a static information message, as it has certain
behavior on-click, which indicate that an action takes place on clicking (which
would then need to be disabled to avoid confusion). We should either find a way
to disable these behaviors or find a replacement. I'm not sure what is a good
replacement is, if we end up going that route, but maybe twellington@ knows.

[Charlie Harrison, 2017/05/23 17:12:18]

I'm fine with adding a second subtitle which we did discuss before. Not
implemented in the current PS though.

raymes: Can you confirm that this is an OK solution?
Acknowledged.

[raymes, 2017/05/23 22:29:01]

I chatted with Charlie offline. I'm ok not showing a banner (I don't think
that's great either) but my concern was that afaik nothing else shows a subtitle
here, and I'm not sure that it fits in well with the existing design of the UI.
In the long term I think we want to show subtitles but we should come up with a
good design.

My preference as a short term, simple solution would be just to modify the text
that's displayed in the option for the setting. There's a precedent for doing
this with the default search engine geolocation setting. 

In any case, it may be good to land a simple solution and iron out the details
with a UX designer. 

     <PreferenceCategory
         android:key="site_heading"
         android:title="@string/website_settings_site_category" />
     <org.chromium.chrome.browser.preferences.TextMessagePreference
         android:key="site_title" />
     <PreferenceCategory
         android:key="site_usage"
         android:title="@string/website_settings_usage_category" />
     <org.chromium.chrome.browser.preferences.website.ClearWebsiteStorage
         android:key="clear_data"
@@ skipping 15 matching lines @@
         android:key="camera_permission_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="microphone_permission_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="push_notifications_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="javascript_permission_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="popup_permission_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="subresource_filter_permission_list" />

[Finnur, 2017/05/23 15:37:13]

Friendly reminder to replace the use of the... I think... popups icon (if not
done already). :)

[Charlie Harrison, 2017/05/23 17:12:18]

Got it. The icons should be ready but we aren't ready to land them quite yet.

     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="background_sync_permission_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="protected_media_identifier_permission_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="autoplay_permission_list" />
     <org.chromium.chrome.browser.preferences.ChromeBaseListPreference
         android:key="midi_sysex_permission_list" />
 
     <org.chromium.chrome.browser.preferences.ButtonPreference
         android:key="reset_site_button"
         android:title="@string/website_reset" />
 </PreferenceScreen>