Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: scripts/slave/recipe_modules/bot_update/api.py

Issue 288843003: Let bot_update recipe api force usage of bot_update. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/bot_update.py ('k') | scripts/slave/recipe_modules/bot_update/test_api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/bot_update/api.py
diff --git a/scripts/slave/recipe_modules/bot_update/api.py b/scripts/slave/recipe_modules/bot_update/api.py
index fe040e7945459da0abaedb24408db01e1a9172d2..0741a1f9c1a2242e197f5f4781e07b8ea6494a88 100644
--- a/scripts/slave/recipe_modules/bot_update/api.py
+++ b/scripts/slave/recipe_modules/bot_update/api.py
@@ -57,7 +57,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
def ensure_checkout(self, gclient_config=None, suffix=None,
patch=True, ref=None, update_presentation=True,
- **kwargs):
+ force=False, **kwargs):
# We can re-use the gclient spec from the gclient module, since all the
# data bot_update needs is already configured into the gclient spec.
cfg = gclient_config or self.m.gclient.c
@@ -118,6 +118,9 @@ class BotUpdateApi(recipe_api.RecipeApi):
cmd = [item for flag_set in flags
for item in flag_set if flag_set[1] is not None]
+ if force: # pragma: no cover
hinoka 2014/05/16 23:33:48 Lets actually add coverage for this, via a fake bu
agable 2014/05/19 16:25:19 Done, PTAL.
+ cmd.append('--force')
+
# Inject Json output for testing.
git_mode = self.m.properties.get('mastername') in GIT_MASTERS
first_sln = cfg.solutions[0].name
« no previous file with comments | « scripts/slave/bot_update.py ('k') | scripts/slave/recipe_modules/bot_update/test_api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698