Issue 2888413002: Fix off-by-one error in DBC interpreter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2888413002: Fix off-by-one error in DBC interpreter (Closed)

Created:
3 years, 7 months ago by erikcorry

Modified:
3 years, 7 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/simulator_dbc.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

erikcorry

Committed patchset #1 (id:1) manually as bd01ce38cedc6d4018d55550e0d0c3b4dda9d339 (presubmit successful).

3 years, 7 months ago (2017-05-19 06:47:37 UTC) #4

zra

lgtm Sorry I was on vacation, but in the future it would probably be better ...

3 years, 7 months ago (2017-05-22 03:34:44 UTC) #5

erikcorry

3 years, 7 months ago (2017-05-22 08:05:36 UTC) #6

Message was sent while issue was closed.

Sorry about that.  We talked about it in the office, but should have done the
formalities right.