components/ntp_tiles/icon_cacher_impl.h - Issue 2888393002: [Icon cacher] Add metrics for downloading favicons for NTP Tiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/icon_cacher_impl.h

Issue 2888393002: [Icon cacher] Add metrics for downloading favicons for NTP Tiles (Closed)

Patch Set: Robert's comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/icon_cacher_impl.h

diff --git a/components/ntp_tiles/icon_cacher_impl.h b/components/ntp_tiles/icon_cacher_impl.h

index 85d02b760f1e7ac6752aeecdfe85dfa62d3b5e07..a124b2c21d2c0a72ab1ebd77388cbf0a2c20c77d 100644

--- a/components/ntp_tiles/icon_cacher_impl.h

+++ b/components/ntp_tiles/icon_cacher_impl.h

@@ -83,6 +83,8 @@ class IconCacherImpl : public IconCacher {

const GURL& page_url,

const favicon_base::LargeIconResult& result);

+ void OnMostLikelyFaviconDownloaded(const GURL& request_url, bool success);

bool StartRequest(const GURL& request_url,

const base::Closure& icon_available);

void FinishRequestAndNotifyIconAvailable(const GURL& request_url,

« no previous file with comments | « no previous file | components/ntp_tiles/icon_cacher_impl.cc » ('j') | no next file with comments »