tools/metrics/histograms/histograms.xml - Issue 2888393002: [Icon cacher] Add metrics for downloading favicons for NTP Tiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2888393002: [Icon cacher] Add metrics for downloading favicons for NTP Tiles (Closed)

Patch Set: Comments of Chris Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 3cb4e1df495072edb9f3a50c9caa48d1d4a48e68..5427e33976e0c2ca13429e1029dcb723dd3e2dff 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -44059,6 +44059,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="NewTabPage.TileFaviconFetched.popular"

rkaplow 2017/05/19 20:19:11 name nit, usually we do caps in between segments,

jkrcal 2017/05/22 07:59:42 Done.

+ enum="NTPTileFaviconFetchResult">

+ <owner>jkrcal@chromium.org</owner>

+ <summary>

+ Mobile only. The result of fetching a favicon for a tile on the New Tab

+ Page. This is recorded for each gray PopularSites tile on the New Tab Page

+ once per updating the set of tiles (notably upon each NTP impression).

+ </summary>

+</histogram>

+<histogram name="NewTabPage.TileFaviconFetched.server"

+ enum="NTPTileFaviconFetchResult">

+ <owner>jkrcal@chromium.org</owner>

+ <summary>

+ Mobile only. The result of fetching a favicon for a tile on the New Tab

+ Page. This is recorded for each gray MostVisited tile on the New Tab Page

+ once per lifetime of Chrome (there as an in-memory cache of failed

+ requests).

+ </summary>

+</histogram>

<owner>treib@chromium.org</owner>