Minimize the delegate dependencies for non persistent notifications.

content/browser/notifications/notification_event_dispatcher_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
 #define CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
 
+#include <map>
+
 #include "base/macros.h"
 #include "base/memory/singleton.h"
 #include "content/public/browser/notification_database_data.h"
 #include "content/public/browser/notification_event_dispatcher.h"
 
 namespace content {
 
 class NotificationEventDispatcherImpl : public NotificationEventDispatcher {
  public:
   // Returns the instance of the NotificationEventDispatcherImpl. Must be called
   // on the UI thread.
   static NotificationEventDispatcherImpl* GetInstance();
 
   // NotificationEventDispatcher implementation.
   void DispatchNotificationClickEvent(
       BrowserContext* browser_context,
       const std::string& notification_id,
       const GURL& origin,
       int action_index,
       const base::NullableString16& reply,
       const NotificationDispatchCompleteCallback& dispatch_complete_callback)
       override;
   void DispatchNotificationCloseEvent(
       BrowserContext* browser_context,
       const std::string& notification_id,
       const GURL& origin,
       bool by_user,
       const NotificationDispatchCompleteCallback& dispatch_complete_callback)
       override;
+  void DispatchNonPersistentShowEvent(
+      const std::string& notification_id) override;
+  void DispatchNonPersistentClickEvent(
+      const std::string& notification_id) override;
+  void DispatchNonPersistentCloseEvent(
+      const std::string& notification_id) override;
+
+  void RendererGone(int renderer_id);
+  void RegisterNonPersistentNotification(const std::string& notification_id,
+                                         int renderer_id,
+                                         int non_persistent_id);

[Peter Beverloo, 2017/06/01 17:56:27]

nit: please document these methods

[Miguel Garcia, 2017/06/02 12:37:13]

Done.

 
  private:
   NotificationEventDispatcherImpl();
   ~NotificationEventDispatcherImpl() override;
 
+  // Notification Id -> renderer Id
+  std::map<std::string, int> notification_renderers_;
+
+  // Notification Id -> non persistent Id.

[Peter Beverloo, 2017/06/01 17:56:27]

non-persistent notification id. Probably should name these members
notification_renderer_id_ and notification_non_persistent_id_ as well if you do
decide to stick with them because it's super ambiguous.

[Miguel Garcia, 2017/06/02 12:37:13]

Done.

+  std::map<std::string, int> notification_ids_;
+
   friend struct base::DefaultSingletonTraits<NotificationEventDispatcherImpl>;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationEventDispatcherImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_