Minimize the delegate dependencies for non persistent notifications.

chrome/browser/notifications/native_notification_display_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/native_notification_display_service.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/nullable_string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/message_center_display_service.h"
 #include "chrome/browser/notifications/non_persistent_notification_handler.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_delegate.h"
 #include "chrome/browser/notifications/notification_handler.h"
 #include "chrome/browser/notifications/notification_platform_bridge.h"
 #include "chrome/browser/notifications/persistent_notification_handler.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/notification_event_dispatcher.h"
 #include "extensions/features/features.h"
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 #include "chrome/browser/extensions/api/notifications/extension_notification_handler.h"
 #endif
 
 namespace {
 
 std::string GetProfileId(Profile* profile) {
 #if defined(OS_WIN)
@@ skipping 52 matching lines @@
 }
 
 void NativeNotificationDisplayService::Display(
     NotificationCommon::Type notification_type,
     const std::string& notification_id,
     const Notification& notification) {
   if (notification_bridge_ready_) {
     notification_bridge_->Display(notification_type, notification_id,
                                   GetProfileId(profile_),
                                   profile_->IsOffTheRecord(), notification);
-    notification.delegate()->Display();
-    NotificationHandler* handler = GetNotificationHandler(notification_type);
-    handler->RegisterNotification(notification_id, notification.delegate());
+    // Unlike all other notifications non persistent notifications require
+    // an event after the notification has been displayed.
+    if (notification_type == NotificationCommon::NON_PERSISTENT) {

[Peter Beverloo, 2017/06/01 17:56:27]

This is where OnShow() could be fired. (Or maybe in the NDS since this class
doesn't know about it.)

[Miguel Garcia, 2017/06/02 12:37:13]

Yeah makes sense, I will add it to the next patch.

+      content::NotificationEventDispatcher::GetInstance()
+          ->DispatchNonPersistentShowEvent(notification_id);
+    }
   } else if (message_center_display_service_) {
     message_center_display_service_->Display(notification_type, notification_id,
                                              notification);
   } else {
     actions_.push(base::BindOnce(&NativeNotificationDisplayService::Display,
                                  weak_factory_.GetWeakPtr(), notification_type,
                                  notification_id, notification));
   }
 }
 
@@ skipping 67 matching lines @@
   notification_handlers_.erase(notification_type);
 }
 
 NotificationHandler* NativeNotificationDisplayService::GetNotificationHandler(
     NotificationCommon::Type notification_type) {
   DCHECK(notification_handlers_.find(notification_type) !=
          notification_handlers_.end())
       << notification_type << " is not registered.";
   return notification_handlers_[notification_type].get();
 }