Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp

Issue 2888283006: CSS: Use count position values with 3 parts (Closed)
Patch Set: use count in the property APIs Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
index 393a62be5f36e308c2faed34b923f99236383ae9..f2b443aa9b1e9b288e51f05f73918d4876b5aa52 100644
--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
@@ -34,9 +34,12 @@ static CSSBasicShapeCircleValue* ConsumeBasicShapeCircle(
if (ConsumeIdent<CSSValueAt>(args)) {
CSSValue* center_x = nullptr;
CSSValue* center_y = nullptr;
- if (!ConsumePosition(args, context.Mode(), UnitlessQuirk::kForbid, center_x,
- center_y))
+ auto syntax = CSSPropertyParserHelpers::PositionSyntax::kPermitThreeValues;
+ if (!ConsumePosition(args, context, UnitlessQuirk::kForbid, syntax,
+ center_x, center_y))
return nullptr;
+ if (syntax == CSSPropertyParserHelpers::PositionSyntax::kCountThreeValues)
+ context.Count(UseCounter::kThreeValuedPositionBasicShape);
shape->SetCenterX(center_x);
shape->SetCenterY(center_y);
}
@@ -57,9 +60,12 @@ static CSSBasicShapeEllipseValue* ConsumeBasicShapeEllipse(
if (ConsumeIdent<CSSValueAt>(args)) {
CSSValue* center_x = nullptr;
CSSValue* center_y = nullptr;
- if (!ConsumePosition(args, context.Mode(), UnitlessQuirk::kForbid, center_x,
- center_y))
+ auto syntax = CSSPropertyParserHelpers::PositionSyntax::kPermitThreeValues;
+ if (!ConsumePosition(args, context, UnitlessQuirk::kForbid, syntax,
+ center_x, center_y))
return nullptr;
+ if (syntax == CSSPropertyParserHelpers::PositionSyntax::kCountThreeValues)
+ context.Count(UseCounter::kThreeValuedPositionBasicShape);
shape->SetCenterX(center_x);
shape->SetCenterY(center_y);
}

Powered by Google App Engine
This is Rietveld 408576698