third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp - Issue 2888283006: CSS: Use count position values with 3 parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

Issue 2888283006: CSS: Use count position values with 3 parts (Closed)

Patch Set: use count in the property APIs Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp ('K') | « third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

index f3a59be6f4af1bd777a7f813fef79f216fb69169..89981212106960d3cacb0b360fc35d93b75601d1 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

@@ -18,8 +18,9 @@ const CSSValue* CSSPropertyAPIOffsetPosition::parseSingleValue(

CSSValueID id = range.Peek().Id();

if (id == CSSValueAuto)

return CSSPropertyParserHelpers::ConsumeIdent(range);

+ auto syntax = CSSPropertyParserHelpers::PositionSyntax::kRejectThreeValues;

CSSValue* value = CSSPropertyParserHelpers::ConsumePosition(

- range, context.Mode(), CSSPropertyParserHelpers::UnitlessQuirk::kForbid);

+ range, context, CSSPropertyParserHelpers::UnitlessQuirk::kForbid, syntax);

// Count when we receive a valid position other than 'auto'.

if (value && value->IsValuePair())