Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Issue 2888283006: CSS: Use count position values with 3 parts (Closed)
Patch Set: use count in the property APIs Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
index e1f2a5f6a246ddc69af242a03f058341d0602292..87d1890a3ac57a7c8ea59891cc64b7afda4c6412 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
@@ -37,6 +37,12 @@ CSSParserTokenRange ConsumeFunction(CSSParserTokenRange&);
enum class UnitlessQuirk { kAllow, kForbid };
+enum class PositionSyntax {
+ kRejectThreeValues,
+ kPermitThreeValues,
+ kCountThreeValues
Bugs Nash 2017/05/22 04:36:10 the purpose of this enum is unclear to me, it seem
Eric Willigers 2017/05/22 06:08:35 Changed to new approach where the use counter feat
+};
+
CSSPrimitiveValue* ConsumeInteger(
CSSParserTokenRange&,
double minimum_value = -std::numeric_limits<double>::max());
@@ -78,11 +84,13 @@ CSSValue* ConsumeColor(CSSParserTokenRange&,
CSSValue* ConsumeLineWidth(CSSParserTokenRange&, CSSParserMode, UnitlessQuirk);
CSSValuePair* ConsumePosition(CSSParserTokenRange&,
- CSSParserMode,
- UnitlessQuirk);
+ const CSSParserContext&,
+ UnitlessQuirk,
+ PositionSyntax&);
bool ConsumePosition(CSSParserTokenRange&,
- CSSParserMode,
+ const CSSParserContext&,
UnitlessQuirk,
+ PositionSyntax&,
CSSValue*& result_x,
CSSValue*& result_y);
bool ConsumeOneOrTwoValuedPosition(CSSParserTokenRange&,

Powered by Google App Engine
This is Rietveld 408576698