third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-background.html - Issue 2888283006: CSS: Use count position values with 3 parts

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-background.html

Issue 2888283006: CSS: Use count position values with 3 parts (Closed)

Patch Set: two color-stop for conic-gradient example Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/fast/css/scroll-snap-parsing.html ('K') | « third_party/WebKit/LayoutTests/fast/css/scroll-snap-parsing-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-background-position.html » ('j') | third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-background-position.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 'use strict';

	6

	7 test(() => {

	8 let ThreeValuedPositionBackgroundPosition = 1983; // From UseCounter.h
	Bugs Nash 2017/05/22 23:07:09 should this be named differently from UseCounter.h should this be named differently from UseCounter.h? Eric Willigers 2017/05/23 03:20:01 I have copied the convention from other use counte Show quoted text On 2017/05/22 23:07:09, Bugs Nash wrote: > should this be named differently from UseCounter.h? I have copied the convention from other use counter tests. cd third_party/WebKit/LayoutTests ; git grep "UseCounter.h" shows many similar cases. git grep " k[A-Z]" `git grep -H isUseCounted \| cut -d':' -f1 \| sort -u` shows only one example where the name from UseCounter.h was used.
	9

	10 let isCounted = () => internals.isUseCounted(document, ThreeValuedPositionBa ckgroundPosition);

	11 var div = document.createElement('div');

	12
	Bugs Nash 2017/05/22 23:07:09 some tests make sure that other properties with th some tests make sure that other properties with their own use counters don't trigger the use counter in question, some don't (presumably because this would be a redundant check with some other test on the same use counter). the inconsistency is a bit confusing, I would suggest one of the following 1) comment in the tests that do not include this check linking the test that does do this check 2) split out the negative tests into a separate file 3) not sure if this one is possible - bring all the tests for a single use counter into the one file. would require ability to clear the use counter, which may not be possible? Eric Willigers 2017/05/23 03:20:01 Comments added. clearing the use counter is not po Show quoted text On 2017/05/22 23:07:09, Bugs Nash wrote: > some tests make sure that other properties with their own use counters don't > trigger the use counter in question, some don't (presumably because this would > be a redundant check with some other test on the same use counter). the > inconsistency is a bit confusing, I would suggest one of the following > 1) comment in the tests that do not include this check linking the test that > does do this check > 2) split out the negative tests into a separate file > 3) not sure if this one is possible - bring all the tests for a single use > counter into the one file. would require ability to clear the use counter, which > may not be possible? Comments added. clearing the use counter is not possible AFAIK.
	13 div.style = 'background: left;';

	14 div.style = 'background: left 10%;';

	15 div.style = 'background: left 10% top 20%;';

	16 assert_false(isCounted(),

	17 '1,2,4 values should not be counted');

	18

	19 div.style = 'background: left 10% top;';

	20 assert_true(isCounted(),

	21 'background should be counted');

	22 }, 'Three valued position syntax is use counted for background');

	23 </script>

OLD	NEW