VR: Fix HTTP warning staying visible after exiting WebVR.

chrome/browser/android/vr_shell/ui_scene.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 103 matching lines @@
     // current frame. It may throttle, for example.
     element->OnBeginFrame(current_time);
 
     element->set_dirty(true);
   }
   for (auto& element : ui_elements_) {
     ApplyRecursiveTransforms(element.get());
   }
 }
 
-UiElement* UiScene::GetUiElementById(int element_id) {
+UiElement* UiScene::GetUiElementById(int element_id) const {
   for (const auto& element : ui_elements_) {
     if (element->id() == element_id) {
       return element.get();
     }
   }
   return nullptr;
 }
 
+UiElement* UiScene::GetUiElementByIdentifier(

[Ian Vollick, 2017/05/19 14:42:32]

nit/bikeshed: Id and Identifier are pretty close. Maybe "name"?

[cjgrant, 2017/05/19 15:10:40]

Sure.  I'll adapt that when we close on the NDEBUG topic.

+    UiElementIdentifier identifier) const {
+  DCHECK(identifier != UiElementIdentifier::kNone);
+  for (const auto& element : ui_elements_) {
+    if (element->identifier() == identifier) {
+      return element.get();
+    }
+  }
+  return nullptr;
+}
+
 std::vector<const UiElement*> UiScene::GetWorldElements() const {
   std::vector<const UiElement*> elements;
   for (const auto& element : ui_elements_) {
     if (element->IsVisible() && !element->lock_to_fov()) {
       elements.push_back(element.get());
     }
   }
   return elements;
 }
 
@@ skipping 85 matching lines @@
 
 // TODO(mthiesse): Move this to UiSceneManager.
 void UiScene::OnGLInitialized() {
   gl_initialized_ = true;
   for (auto& element : ui_elements_) {
     element->Initialize();
   }
 }
 
 }  // namespace vr_shell