Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js |
| index b485217254a25c2215a4af13ce7d2b87f319ab0e..761de07779098e95cd0b34f0d20fe90ee7f11d04 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js |
| @@ -260,7 +260,8 @@ Audits2.Audits2Panel = class extends UI.PanelWithSidebar { |
| console.error(err); |
| this._statusElement.textContent = ''; |
| this._statusIcon.classList.add('error'); |
| - this._statusElement.createTextChild(Common.UIString('We ran into an error. ')); |
| + this._statusElement.createTextChild(Common.UIString('Ah, sorry! We ran into an error: ')); |
| + this._statusElement.createChild('em').createTextChild(err.message); |
| this._createBugReportLink(err, this._statusElement); |
| } |
| @@ -272,12 +273,16 @@ Audits2.Audits2Panel = class extends UI.PanelWithSidebar { |
| var baseURI = 'https://github.com/GoogleChrome/lighthouse/issues/new?'; |
| var title = encodeURI('title=DevTools Error: ' + err.message.substring(0, 60)); |
| - var qsBody = ''; |
| - qsBody += '**Initial URL**: ' + this._inspectedURL + '\n'; |
| - qsBody += '**Chrome Version**: ' + navigator.userAgent.match(/Chrome\/(\S+)/)[1] + '\n'; |
| - qsBody += '**Error Message**: ' + err.message + '\n'; |
| - qsBody += '**Stack Trace**:\n ```' + err.stack + '```'; |
| - var body = '&body=' + encodeURI(qsBody); |
| + var issueBody = ` |
| +**Initial URL**: ${this._inspectedURL} |
| +**Chrome Version**: ${navigator.userAgent.match(/Chrome\/(\S+)/)[1]} |
| +**Error Message**: ${err.message} |
| +**Stack Trace**: |
| +\`\`\` |
| +${err.stack} |
| +\`\`\` |
| + `; |
| + var body = '&body=' + encodeURI(issueBody.trim()); |
|
phulce
2017/05/18 04:33:01
we should use `encodeURIComponent`, just ran into
|
| var reportErrorEl = parentElem.createChild('a', 'audits2-link audits2-report-error'); |
| reportErrorEl.href = baseURI + title + body; |