Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Issue 2888263002: DevTools: Roll Lighthouse binary to 2.0.1-alpha.0 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
index b485217254a25c2215a4af13ce7d2b87f319ab0e..75a2dc0ebfd36dbf7e3cb1de1b627ff8b5cce24b 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
@@ -272,12 +272,16 @@ Audits2.Audits2Panel = class extends UI.PanelWithSidebar {
var baseURI = 'https://github.com/GoogleChrome/lighthouse/issues/new?';
var title = encodeURI('title=DevTools Error: ' + err.message.substring(0, 60));
- var qsBody = '';
- qsBody += '**Initial URL**: ' + this._inspectedURL + '\n';
- qsBody += '**Chrome Version**: ' + navigator.userAgent.match(/Chrome\/(\S+)/)[1] + '\n';
- qsBody += '**Error Message**: ' + err.message + '\n';
- qsBody += '**Stack Trace**:\n ```' + err.stack + '```';
- var body = '&body=' + encodeURI(qsBody);
+ var issueBody = `
+**Initial URL**: ${this._inspectedURL}
+**Chrome Version**: ${navigator.userAgent.match(/Chrome\/(\S+)/)[1]}
+**Error Message**: ${err.message}
+**Stack Trace**:
+\`\`\`
+${err.stack}
+\`\`\`
+ `;
+ var body = '&body=' + encodeURI(issueBody);
phulce 2017/05/18 00:48:06 wanna trim it too for newlines?
paulirish 2017/05/18 01:03:38 done
var reportErrorEl = parentElem.createChild('a', 'audits2-link audits2-report-error');
reportErrorEl.href = baseURI + title + body;
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698