Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2888223003: Build Cronet for iOS with bitcode enabled

Created:
3 years, 7 months ago by kapishnikov
Modified:
3 years, 7 months ago
Reviewers:
lilyhoughton, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Build Cronet for iOS with bitcode enabled BUG=723816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/cronet/tools/cr_cronet.py View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/tools/package_ios.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
kapishnikov
PTAL. Tested it with a sample Xcode project that was build with bitcode enabled and ...
3 years, 7 months ago (2017-05-18 03:55:29 UTC) #5
mef
On 2017/05/18 03:55:29, kapishnikov wrote: > PTAL. Tested it with a sample Xcode project that ...
3 years, 7 months ago (2017-05-18 14:09:03 UTC) #8
kapishnikov
3 years, 7 months ago (2017-05-19 19:23:28 UTC) #9
I have updated the linked bug with more info.

On 2017/05/18 14:09:03, mef wrote:
> On 2017/05/18 03:55:29, kapishnikov wrote:
> > PTAL. Tested it with a sample Xcode project that was build with bitcode
> enabled
> > and thus required that all embedded frameworks were also built with bitcode
> > enabled.
> 
> Cool, thanks for trying this out! A couple of questions:
> 
> - How does it affect the binary size of device release framework binaries?
The intermediate binary size increased very significantly from 6MB to 1.2GB. If
an embedding app is not built with bitcode enabled, the size goes back to 6MB
since the bitcode is automatically stripped out. We don't know what the size
would be if the app with bitcode is submitted to the appstore and recompiled by
Apple.

> - Does it do the right thing for simulator and/or debug builds?
It doesn't include bitcode in debug since it only makes sense when the app is
submitted to the appstore (which supposed to be a release version). However, it
may complicate the development process a little bit, since the developer will
need to change the project settings before creating the release version.

The simulator version is built without bitcode. That is correct since bitcode
can only be added for ARM.

Powered by Google App Engine
This is Rietveld 408576698