third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp - Issue 2888203006: Move the logic to retrieve the WebPluginContainer to LocalFrame and Node.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

Issue 2888203006: Move the logic to retrieve the WebPluginContainer to LocalFrame and Node. (Closed)

Patch Set: Address code review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

index b1ed72e6131dbd161b54a432dfae687ec0b34b55..ab1eec888a8626faaa36530a9a5bb49db12fcb2f 100644

--- a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

@@ -158,10 +158,10 @@ InputMethodController& WebInputMethodControllerImpl::GetInputMethodController()

WebPlugin* WebInputMethodControllerImpl::FocusedPluginIfInputMethodSupported()

const {

- WebPluginContainerBase* container =

- WebLocalFrameImpl::CurrentPluginContainer(GetFrame());

- if (container && container->SupportsInputMethod())

+ WebPluginContainerBase* container = GetFrame()->GetWebPluginContainerBase();

+ if (container && container->SupportsInputMethod()) {

return container->Plugin();

+ }

return nullptr;

}