Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2888203006: Move the logic to retrieve the WebPluginContainer to LocalFrame and Node. (Closed)
Patch Set: Address code review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 4c00a5b8f81b6c7df73b21246a5d0656f136b6f6..984e985fdf9018faa6f10b6d46ea8d579182cd08 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -81,6 +81,7 @@ class PluginData;
class ScriptController;
class SpellChecker;
class WebFrameScheduler;
+class WebPluginContainerBase;
class WebURLLoader;
extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<LocalFrame>;
@@ -244,6 +245,12 @@ class CORE_EXPORT LocalFrame final : public Frame,
// for adding a callback multiple times.
static void RegisterInitializationCallback(FrameInitCallback);
+ // If the frame hosts a PluginDocument, this method returns the
+ // WebPluginContainerBase that hosts the plugin. If the provided node is a
+ // plugin, then it returns its WebPluginContainerBase. Otherwise, uses the
+ // currently focused element (if any).
haraken 2017/05/22 04:51:44 This looks like a weird semantics. Can we drop the
dcheng 2017/05/22 09:48:29 I agree it's a bit confusing (which is why I was h
slangley 2017/05/22 23:53:25 I added a TODO and will followup with a CL to addr
+ WebPluginContainerBase* GetWebPluginContainerBase(Node* = nullptr) const;
+
private:
friend class FrameNavigationDisabler;

Powered by Google App Engine
This is Rietveld 408576698