Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Side by Side Diff: third_party/WebKit/Source/core/plugins/PluginView.h

Issue 2888203006: Move the logic to retrieve the WebPluginContainer to LocalFrame and Node. (Closed)
Patch Set: Address code review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * Copyright (C) 2014 Opera Software ASA. All rights reserved. 4 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 24 matching lines...) Expand all
35 #include "platform/wtf/text/WTFString.h" 35 #include "platform/wtf/text/WTFString.h"
36 #include "public/platform/WebFocusType.h" 36 #include "public/platform/WebFocusType.h"
37 #include "v8/include/v8.h" 37 #include "v8/include/v8.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 class Event; 41 class Event;
42 class FrameView; 42 class FrameView;
43 class ResourceResponse; 43 class ResourceResponse;
44 class WebLayer; 44 class WebLayer;
45 class WebPluginContainerBase;
45 46
46 // TODO(joelhockey): Remove this class. 47 // TODO(joelhockey): Remove this class.
47 // The only implementation of this class is web/WebPluginContainerImpl. 48 // The only implementation of this class is web/WebPluginContainerImpl.
48 // It can be used directly. 49 // It can be used directly.
49 class CORE_EXPORT PluginView : public FrameOrPlugin { 50 class CORE_EXPORT PluginView : public FrameOrPlugin {
50 public: 51 public:
51 virtual ~PluginView() {} 52 virtual ~PluginView() {}
52 53
53 bool IsPluginView() const override { return true; } 54 bool IsPluginView() const override { return true; }
54 55
(...skipping 15 matching lines...) Expand all
70 virtual bool WantsWheelEvents() { return false; } 71 virtual bool WantsWheelEvents() { return false; }
71 virtual bool SupportsKeyboardFocus() const { return false; } 72 virtual bool SupportsKeyboardFocus() const { return false; }
72 virtual bool SupportsInputMethod() const { return false; } 73 virtual bool SupportsInputMethod() const { return false; }
73 virtual bool CanProcessDrag() const { return false; } 74 virtual bool CanProcessDrag() const { return false; }
74 75
75 virtual void DidReceiveResponse(const ResourceResponse&) {} 76 virtual void DidReceiveResponse(const ResourceResponse&) {}
76 virtual void DidReceiveData(const char*, int) {} 77 virtual void DidReceiveData(const char*, int) {}
77 78
78 virtual void UpdateAllLifecyclePhases() {} 79 virtual void UpdateAllLifecyclePhases() {}
79 virtual void InvalidatePaint() {} 80 virtual void InvalidatePaint() {}
81 virtual WebPluginContainerBase* GetWebPluginContainerBase() const {
haraken 2017/05/22 04:51:44 Can we probably make this a pure virtual method?
slangley 2017/05/22 23:53:25 This class has a mix of pure virtual and virtual -
82 return nullptr;
83 }
80 }; 84 };
81 85
82 DEFINE_TYPE_CASTS(PluginView, 86 DEFINE_TYPE_CASTS(PluginView,
83 FrameOrPlugin, 87 FrameOrPlugin,
84 frame_or_plugin, 88 frame_or_plugin,
85 frame_or_plugin->IsPluginView(), 89 frame_or_plugin->IsPluginView(),
86 frame_or_plugin.IsPluginView()); 90 frame_or_plugin.IsPluginView());
87 91
88 } // namespace blink 92 } // namespace blink
89 93
90 #endif // PluginView_h 94 #endif // PluginView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698